Latest update causes plugin to not refresh properly

mattboehm / vim-accordion

A vim window manager for people who love splits

101 stars 3 forks source link

Latest update causes plugin to not refresh properly #30

Closed svermeulen closed 10 years ago

svermeulen commented 10 years ago

Repro steps (using vanilla vim with just this plugin):

create a new v split
Run Accordion 1
Observe that that works correctly and the window is maximized
Run Accordion 2
Observe that nothing happens
Move to other window
Observe the correct layout, with both windows visible
Run Accordion 1
Nothing happens again

This issue seems to have been created recently so I'm just using an older build for now

mattboehm commented 10 years ago

Thanks, I'm looking into this.

mattboehm commented 10 years ago

Should be fixed now. If you still see any issues, let me know.

svermeulen commented 10 years ago

Awesome! Thanks.

svermeulen commented 10 years ago

Hmm for some reason I'm getting this error now:

error

mattboehm commented 10 years ago

Sorry about that! I had fixed that but while in another branch and did not realize that the problem existed on master. I've pushed the fix. I'm going to have to start looking into automated testing. I currently try to test all the features before pushing, but there are a lot of combinations, so it's easy to miss things.

svermeulen commented 10 years ago

No worries, I know the pain of vim scripting. I've had a lot of success using vimbot (with rspec) to test my plugins, but I know there's other testing frameworks out there as well.

I updated and that fixed the first error but now I'm seeing this when I close windows: error

mattboehm commented 10 years ago

Case in point... fixed. Thanks for your feedback.