mattboehm / vim-unstack

Vim plugin for parsing stack traces and opening the files
286 stars 15 forks source link

Vertically centre signs #19

Closed elzibubble closed 10 years ago

elzibubble commented 10 years ago

When I unstack, the error is only 5 lines from the top. This is rarely far enough to give context. It would be more useful, to me at least, if the marked line was in the centre of the screen.

mattboehm commented 10 years ago

Sorry, some of the discussion in #20 should have gone in here. I'm working on this now and will include an option for unstack_line_position=["top"|"middle"|"bottom"]. Might tweak the wording on that and am open to suggestions.

mattboehm commented 10 years ago

This and #20 should now be fixed; let me know if you find any issues.

elzibubble commented 10 years ago

Fantastic, thanks again!

One slight curiosity, for some reason now if I use :UnstackFromSelection there's a hit enter prompt. This wasn't there before! If I use visual mode I don't get prompted.

http://asciinema.org/a/8011

:messages output:

session.vim 2.4.8: Opened global 'rt' session from ~/Dropbox/vim/sessions/rt.vim.
  File "nova/tests/compute/test_resource_tracker.py", line 910, in test_same_host^@    self._assert(1 + FAKE_VIRT_MEMORY_OVERHEAD, 'memory_mb_used')^@  File "nova/tests/compute/test_resource_tracker.py", line 512, in _assert^@    self.assertEqual(value, x)^@  File "/home/lealexis/w/os-nova/.venv/local/lib/python2.7/site-packages/testtools/testcase.py", line 321, in assertEqual^@    self.assertThat(observed, matcher, message)^@  File "/home/lealexis/w/os-nova/.venv/local/lib/python2.7/site-packages/testtools/testcase.py", line 406, in assertThat^@    raise mismatch_error
"nova/tests/compute/test_resource_tracker.py" 1137 lines --0%--
"nova/tests/compute/test_resource_tracker.py" 1137 lines --0%--
".venv/lib/python2.7/site-packages/testtools/testcase.py" 959L, 34170C
".venv/lib/python2.7/site-packages/testtools/testcase.py" 959 lines --0%--
mattboehm commented 10 years ago

Weird, I'll look into it.