search

mattboehm / vim-unstack

Vim plugin for parsing stack traces and opening the files
286 stars 15 forks source link

unstack seems to :set scrolloff=5 #20

Closed elzibubble closed 10 years ago

elzibubble commented 10 years ago

I have scrolloff set to 15 in my .vimrc and executing :set so? after I start Vim confirms this has applied. However after using unstack, the value has changed to 5. Please don't change my settings!

mattboehm commented 10 years ago

Whoops! Sorry, when I initially implemented this, I thought 'scrolloff' was a buffer/window local setting and wanted the unstack windows to have some value set. Now that I know it's global, I'll remove this and either use z. or recommend it to users.

mattboehm commented 10 years ago

If I try to center the lines, it puts them all over the place for lines at the top/bottom of the file. I'm going to still use z+ but will kill the current scrollback logic and may add a setting for unstack_scrollback that changes the scrollback only while unstack is opening the files and only if it is explicitly set.

elzibubble commented 10 years ago

FWIW I'd be very happy with z., lines near the top/bottom be darned :)

z+ seems almost the opposite of what's needed, given the context is usually above the line in question? Maybe an option like unstack_context=above/below/center ? Perhaps with an unstack_scrolloff option to set the temporary value of scrolloff unstack uses. I'd prefer unstack_scrolloff to unstack_scrollback to be consistent with the builtin option.

On 3 March 2014 15:35, Matthew Boehm notifications@github.com wrote:

If I try to center the lines, it puts them all over the place for lines at the top/bottom of the file. I'm going to still use z+ but will kill the current scrollback logic and may add a setting for unstack_scrollbackthat changes the scrollback only while unstack is opening the files and only if it is explicitly set.

Reply to this email directly or view it on GitHubhttps://github.com/mattboehm/vim-unstack/issues/20#issuecomment-36521245 .

Cheers, Alexis

mattboehm commented 10 years ago

Er right, I meant to say unstack_scrolloff. I like your idea for unstack_context. I may implement that before pushing out the changes I've already made (should still be able to finish it tonight).