mattbrailsford / umbraco-fluidity

A fluent CRUD user interface generator for Umbraco
https://our.umbraco.org/projects/backoffice-extensions/fluidity/
Apache License 2.0
48 stars 40 forks source link

Add in MakeAllReadonly() function for EditorConfig #53

Closed jamiepollock closed 6 years ago

jamiepollock commented 6 years ago

Hello! Loving the work MakeReadonly() on FieldConfigs would a potential top level function for EditorConfig called MakeAllReadonly() fit in the project?

This would be a time saver for having to set each field as MakeReadonly().

I'm happy to look into a PR if you're happy with the expected functionality.

I'm expecting this to be a "default" and if a developer really wants to they can override it on a per field basis.

Thanks, Jamie

mattbrailsford commented 6 years ago

It shouldn't be necessary. I've recently added (not yet released) that setting a collection read only, auto makes editor fields readonly unless a data type is explicitly set on a field.

On Fri, 1 Jun 2018, 7:27 pm Jamie Pollock, notifications@github.com wrote:

Hello! Loving the work MakeReadonly() on FieldConfigs would a potential top level function for EditorConfig called MakeAllReadonly() fit in the project?

This would be a time saver for having to set each field as MakeReadonly().

I'm happy to look into a PR if you're happy with the expected functionality.

I'm expecting this to be a "default" and if a developer really wants to they can override it on a per field basis.

Thanks, Jamie

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/umco/umbraco-fluidity/issues/53, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgLyfQdt2iqpcaUuN6t225QEaNWs95Aks5t4Yd9gaJpZM4UXIGw .

jamiepollock commented 6 years ago

Ah well then I'm looking forward to that release! I noticed it wasn't current behaviour in the live version. :)

I'm happy to close this issue now I know it's coming up in a future release

Thanks Matt! #h5yr!.