search

mattbrictson / bundle_update_interactive

A stylish interactive mode for Bundler, inspired by `yarn upgrade-interactive`
MIT License
137 stars 3 forks source link

Change all/reverse key bindings to unmodified a/r #18

Closed mattbrictson closed 1 month ago

mattbrictson commented 1 month ago

Currently, ctrl-a and ctrl-r are used for select-all and reverse-selection. We get these as default key bindings from tty-prompt, the library we use for the multi-select menu. As discussed in #16, these defaults are a bit problematic.

This PR changes the key bindings to a and r instead (i.e. without the control-key modifier).

I also added test coverage for these, as well as the j/k and n/p bindings added in #4.

Fixes #16

mattbrictson commented 1 month ago

@dylnclrk since you contributed recent changes to key bindings, I am wondering if you have any thoughts on this PR? I want to be sure I'm not introducing key bindings that are going to confuse heavy keyboard users.

dylnclrk commented 1 month ago

IMO a/r seem like good choices for these.

t does reverse-selection ("toggle all") in dired, but I think if you go down the route of trying to match too much it will get confusing.