mattbrictson / bundle_update_interactive

A stylish interactive mode for Bundler, inspired by `yarn upgrade-interactive`
MIT License
137 stars 3 forks source link

Don't use GitHub Releases as changelog URL if it is empty #43

Closed mattbrictson closed 3 weeks ago

mattbrictson commented 3 weeks ago

Some gems, like parallel, have no changelog at all. They are hosted on GitHub but don't make use of GitHub Releases, either.

Before, update-interactive would show GitHub Releases as the changelog URL in this scenario, even though the page doesn't contain any useful information. This is a bug.

parallel  1.25.1  →  1.26.3  https://github.com/grosser/parallel/releases

This PR fixes the bug by doing a better job at testing that the GitHub Releases page contains actual releases. If no useful changelog URL can be found, update-interactive now falls back to showing the gem's home page instead.

parallel  1.25.1  →  1.26.3  https://github.com/grosser/parallel