Closed inkstak closed 1 year ago
Interesting idea! Let me think this over. I am not opposed to it, but it seems weird for CLI#run
to return a value. A CLI, by nature, takes its inputs and provides its outputs via the command-line. So getting back an object from run
doesn't feel right.
I would rather the updates
be obtained by an explicit method, rather than a return value.
Something like this:
cli = Bundleup::Cli.new([])
cli.run
updates = cli.updated_gems
It's a small distinction. Would that work for you?
I understand and by extension it could open the way to a pinned_gems
method for those who need it.
@inkstak great! If you could make that small refactor and add a test, I'll merge this in. I'm also happy to add a test later, if you get stuck on that part.
Done ! Some tests added and passing. Feel free to refactor as you want ;)
Nice! Tests look great. Much appreciated! 🙏
I would like to integrate bundleup into an overall update script and perform actions accordingly to the gems that have been updated.
For example:
If you might consider these changes, I will try to add tests.