search

mattbrictson / chandler

[unmaintained] chandler syncs your CHANGELOG entries to GitHub's release notes
MIT License
152 stars 15 forks source link

Support for github Authentication Tokens #16

Closed orta closed 8 years ago

orta commented 8 years ago

Helps the discussion in #14

Sorry this took a few weeks, but I needed fresh perspective - once I read https://github.com/mattbrictson/chandler/issues/14#issuecomment-245418267 I really started to grok your testing systems. Thanks for that! Not used mini test 👍 - it's fast.

orta commented 8 years ago

The irony of forgetting a CHANGELOG entry is definitely not lost on me. Danger can help there BTW ;)

mattbrictson commented 8 years ago

The irony of forgetting a CHANGELOG entry is definitely not lost on me. Danger can help there BTW ;)

Good point! In fact I've set it up for one of my other projects already (airbrussh) and would like to do it here as well, but I'm not sure I want to set up another bot. Can I use the @dangerci user as my bot (looks like I can steal the API key from your Travis logs 😉) or do you encourage each repo that uses Danger set up their own bot account?

orta commented 8 years ago

I generally discourage re-using that, but as far as I know very few are using it, so as long the account doesn't get banned - I'm totally fine with it 👍

Will edit PR now, might make that same CHANGELOG change on my own projects

mattbrictson commented 8 years ago

Awesome, thanks again for the PR! 🙇