search

mattbrictson / chandler

[unmaintained] chandler syncs your CHANGELOG entries to GitHub's release notes
MIT License
152 stars 15 forks source link

Gentle Version Handling #36

Open PatrikSteuer opened 7 years ago

PatrikSteuer commented 7 years ago

We would like to use your tool, but we have a continous delivery pipeline in place. This pipeline enforces the build only once principle and creates versions which are extended by an timestamp + commitId.

Our versions look like: 0.1.0-20170405101014+6175ca3224ba086e1b22b7923ba3282aa9d4db01

The used validation regex (Gem::Version::VERSION_PATTERN => \^[0-9]+(.[0-9a-zA-Z]+)*$\ ) does not allow the used "-" and "+" symbols.

Is it possible to allow - and + within the version?

mattbrictson commented 7 years ago

Hi, thanks for the suggestion!

I originally wrote Chandler to support my Ruby projects, so Gem::Version::VERSION_PATTERN was the obvious choice, since it is exactly what rubygems uses internally.

I realize that Chandler now has a wider audience, and I also see opportunities to improve Chandler's handling of version numbers and tags in general, so I am open to changing it.

Would you like to open a PR to change the regex to allow - and +?

PatrikSteuer commented 7 years ago

I am not an ruby developer, but I will give my best. So please review the change carefully once I created a PR

kevinelliott commented 6 years ago

We use a different format for releases. Our format is:

20180312/happy-kid

date and then name (which we autogenerate).

mattbrictson commented 5 years ago

⚠️ This project is no longer actively maintained. I have found myself embracing tools like release-drafter to keep release notes updated automatically, rather than relying on a manually edited CHANGELOG.md. If you are interested in taking over chandler development, let me know by opening an issue.