search

mattbrictson / chandler

[unmaintained] chandler syncs your CHANGELOG entries to GitHub's release notes
MIT License
152 stars 15 forks source link

Add --tag-prefix option #4

Closed mattbrictson closed 8 years ago

mattbrictson commented 8 years ago

Fixes #3.

@jhalterman Can you try out this branch at let me know if it works for you?

Just check out the tag-prefix branch, run rake install to install the gem, and then try running this on your project:

chandler push --dry-run --tag-prefix=typetools-
jhalterman commented 8 years ago

Sweet - works great! I have one more feature I wanted to raise before you cut a new release or anything. Will post separately.

mattbrictson commented 8 years ago

Actually, this may work in a --dry-run but I think it is incomplete. The prefix gets stripped off by the time the GitHub API request is made, which means GitHub won't be able to link the release to the correct tag. I'll have to work on this some more. :disappointed:

jhalterman commented 8 years ago

It worked for me somehow with this one: https://github.com/jhalterman/typetools/releases/tag/0.4.4

I had to use the --version option too though, do to some missing versions in the changelog.

mattbrictson commented 8 years ago

Right. The fundamental problem is the mismatch between the tags and the CHANGELOG entries. The tags are in the format "typetools-0.4.4", but the CHANGELOG has "0.4.4". So I'll need to take that into account, which is why I opened #6.