search

mattbrictson / rails-template

My former app template for Rails 7. All recommendations you see here have been moved to https://github.com/mattbrictson/nextgen
MIT License
1.08k stars 231 forks source link

Add gitignores, rubocop ignores, and change design of error pages #13

Closed zeroc0d3 closed 6 years ago

zeroc0d3 commented 6 years ago

Changelog:

mattbrictson commented 6 years ago

Thanks for the contributions! As a general rule, I am only maintaining the master branch. Therefore I will be closing the PRs for the other branches.

In terms of the changes you've suggested here:

  1. In my opinion IDE-specific ignores do not belong in a project .gitignore file. There will always be OS, editor, and other environment-specific files that need to be ignored, and these vary from developer to developer. I suggest placing these non-project-specific ignores in a global gitignore file, like this: https://stackoverflow.com/a/7335487/4625365
  2. Telling RuboCop to ignore node_modules and bower_components is a great idea. 👍
  3. I'd prefer to use the default Rails error pages.

I'm happy to cherry-pick commit fb7d588 (i.e. # 2 above) if you have no objections.

zeroc0d3 commented 6 years ago

Well great, will check it soon after updated... Thanks

mattbrictson commented 6 years ago

Cherry-pick applied in master @ 6c3f34f