search

mattbrictson / rails-template

My former app template for Rails 7. All recommendations you see here have been moved to https://github.com/mattbrictson/nextgen
MIT License
1.09k stars 231 forks source link

Rails 6 no longer uses `--skip-test-unit` option #23

Closed lorennorman closed 5 years ago

lorennorman commented 5 years ago

From rails new --help:

  -T, [--skip-test], [--no-skip-test]                        # Skip test files
      [--skip-system-test], [--no-skip-system-test]          # Skip system test files

...so your assert_valid_options method needs a slight tweak to account for this properly.

I hesitate to call this an "issue", but I'm getting so much value from your work here and I noticed you've missed something that recently changed, so I'm paying it back!

mattbrictson commented 5 years ago

Nice catch, thanks! Glad to hear this project is helping you! ❤️