Open fbuchinger opened 8 years ago
Hi Franz, Thanks for this. Your name rung a bell and we actually spoke about this years ago. I just searched my email and saw you even mentioned "exiftool.js" hah! I'd forgotten about that. http://photo.stackexchange.com/questions/1503/what-photo-sharing-websites-expose-camera-serial-numbers#comment12727_8800
Your suggestion is a good one and I'd certainly appreciate any help you can offer.
However, the first bug that must be fixed is https://github.com/mattburns/exiftool.js/issues/8 The test suite is not deterministic which means it cannot be trusted! Once that is reliable, then we can make changes without fear of regression etc.
Have you seen this fork of the project by @redaktor ? https://github.com/redaktor/exiftool.js I'd really like to pull these projects together I'm just always too busy...
Cheers, Matt
Hi Matt,
yeah, I also remembered you from our conversation and of stolencamerafinder.net ;-) Glad to hear that you are still committed to photography and metadata. I hope I can help to land some progress on exiftool.js. I wasn't aware of redaktor's fork, but will certainly investigate it, since he already has done some import of exiftool's tag database.
I will also check your testsuite bug. Unfortunately, the coverage testsuite feels a bit bloated at the moment with approx 7000 images, so its pretty hard to work with it. See my other issue #19 for an improvement suggestion.
Best,
Franz
Hi Matt,
first of all congratulations to your great effort of porting exiftool to Javascript! Can't wait to see more progress on this project. Just a quick idea from my side: why don't you import the tag data (i.e. name, data structure, meaning of a tag) from exiftool instead of hard-coding it in your source code?
I see a few advantages of this approach:
How to do it?
exiftool provides the -listx option to dump out (parts of) its tag database to xml, e.g.
would dump out all exif tag info in an xml structure like this:
Obviously one would then have to convert the xml file into multiple JSON files (maybe a default one in English, plus some separate i18n files for the other languages). Finally you have to enhance your Exif parser to understand the format of the JSON files.
In case you are interested I can try to compile a pull request.
Best,
Franz