search

mattcasters / pentaho-pdi-dataset

Set of PDI plugins to more easily work with data sets. We also want to provide unit testing capabilities through input data sets and golden data sets.
Apache License 2.0
30 stars 13 forks source link

Data set for Table Input Step not working #37

Closed Michele100 closed 5 years ago

Michele100 commented 5 years ago

Hi. If there is a Table Input step and the connection to the database is not working (for example, the remote DB is not available), then it's not possible to associate a Unit Test to that step. The Error message panel comes up complaining that the connection : image

diethardsteiner commented 5 years ago

This is especially important in environments that are completely locked down and no proper dev environment is in place (e.g. no MySQL databaser access available at all).

mattcasters commented 5 years ago

I have to ask for a reproduction path. If the Table Input step does not have an input data set then this is normal.

mattcasters commented 5 years ago

OK, I prodded around a bit and it seems like this is an issue with Kettle itself which we'll need to circumvent somehow. I'll fix this over the next couple of days.

diethardsteiner commented 5 years ago

Excellent, thanks a lot!

On 21 Jan 2019, at 10:17, Matt Casters notifications@github.com wrote:

OK, I prodded around a bit and it seems like this is an issue with Kettle itself which we'll need to circumvent somehow. I'll fix this over the next couple of days.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

mattcasters commented 5 years ago

Should be fixed in 3.4.0, give it a try. Thanks for the feedback!

diethardsteiner commented 5 years ago

Thanks a lot! We did a quick check and it seems to be working now. Just a note for everyone who tries to get this working: Make sure that when you define your unit test dataset, that the field column is set to the same name as the field returned by e.g. the Table input step (because since PDI without a working DB connection cannot source any metadata, all the Pentaho PDI dataset plugin can rely on is this mapping that you provide in the dataset dialog).

Michele100 commented 5 years ago

Hi Matt, it seems like the same issue arise when I create a Golden Data Set, as opposed to Input Data (which has been fixed). Thanks.

mattcasters commented 5 years ago

The Golden part is a problem as well but it's slightly harder. I'll look at it later this week.

mattcasters commented 5 years ago

Shuffled some code around, wasn't that big of a deal as I thought.

Michele100 commented 5 years ago

Tested and it's working OK now. Thanks Matt.