search

mattcasters / pentaho-pdi-dataset

Set of PDI plugins to more easily work with data sets. We also want to provide unit testing capabilities through input data sets and golden data sets.
Apache License 2.0
30 stars 13 forks source link

Metastore Unit Test File stores absolute path to ktr - pls make relative or support variables #6

Closed diethardsteiner closed 5 years ago

diethardsteiner commented 7 years ago

Since projects usually involve multiple environments, paths have to be flexible. Currently the metastore unit test file specifies an absolut path for the ktr file. Please either allow the use of variables/parameters or at least a relative path.

mattcasters commented 7 years ago

This is a good point but a relative path does pose serious problems for finding a transformation from the viewpoint of the unit test. So perhaps a possible solution is to set a base folder in the unit test? The filename stored in the unit test metastore object would then be relative to that path. I guess for repositories the problem is not present as much.

diethardsteiner commented 7 years ago

Yes, setting a base folder path in the unit test would be great. With parameter support please ;)

mattcasters commented 6 years ago

Very similar to #15

mattcasters commented 5 years ago

Added base path option and implemented variable UNIT_TESTS_BASE_PATH

mattcasters commented 5 years ago

Also logged when saving:

2018/11/07 09:51:58 - General - Unit test 'graph-output-test UT' : Saved relative path to transformation: ./graph-output-test1.ktr