mattcg / socks5-client

SOCKS v5 client socket implementation in JavaScript for Node.JS.
Other
56 stars 31 forks source link

Remove buffers `noAssert` argument #19

Closed BridgeAR closed 6 years ago

BridgeAR commented 6 years ago

Support for the noAssert argument dropped in the upcoming Node.js v.10. This removes the argument to make sure everything works as it should. Sadly there is not test to verify this currently.

Refs: https://github.com/nodejs/node/pull/18395

BridgeAR commented 6 years ago

Ping @mattcg

mattcg commented 6 years ago

Thank you for this.