search

mattcolman / phaser-list-view

List view class for Phaser. Great for high scoreboards.
http://mattcolman.com/labs/phaser-list-view/index.html
MIT License
115 stars 21 forks source link

Modified some classes by using the es2015 style #5

Closed xtforgame closed 8 years ago

xtforgame commented 8 years ago

Hi Matt,

Please forgive my intrusion. Yesterday I found this project, and started using it in my game.

It is definitely awesome, but I found that there some classes are not written with the es6(es2015) style, so I made some modifications today.

I also changed the constructor of Scroller by adding a required argument ( maskLimits ), to prevent a potential bug in init() function of Scroller.

If you have any problems, please me know, thanks.

Rick Chen

mattcolman commented 8 years ago

@xtforgame hey thanks for contributing! Code looks good. tbh when I wrote this I had just read an article about how es6 classes are terrible! haha...but people are dramatic, I don't agree with that, so I'm happy to merge this, I just need to test the code first. Cheers!

mattcolman commented 8 years ago

@xtforgame I've tested your code and happy to merge. It now has conflicts which I've solved in this branch https://github.com/mattcolman/phaser-list-view/tree/xtforgame-master , if you can please solve conflicts on your branch I will merge this PR. cheers.

mattcolman commented 8 years ago

@xtforgame ah ok, I just wanted to make sure you get credit for your work, and github is smart enough to do this. Merged my branch with your fixes, closing this PR too. Thanks again for contributing!!