search

mattcolman / phaser-manifest-loader

Phaser Manifest Loader
http://mattcolman.com/labs/phaser-manifest-loader/index.html
MIT License
30 stars 7 forks source link

Adding support for Json files #9

Open jjwallace opened 6 years ago

jjwallace commented 6 years ago

Modified AssetLoader and Manifest loader, compiled. (may need more modifications, current test not showing json in game)

Received: Phaser.Cache.getText: Key "lvl1" not found in Cache.

For assets/json/lvl1.json

mattcolman commented 6 years ago

what do you mean "(may need more modifications, current test not showing json in game)"?

mattcolman commented 6 years ago

also this project uses yarn, so I don't think we want the package-lock.json

jjwallace commented 6 years ago

Oh right, my bad, I must have compiled with npm oops

On Wed, Aug 15, 2018, 16:45 Matt Colman notifications@github.com wrote:

also this project uses yarn, so I don't think we want the package-lock.json

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mattcolman/phaser-manifest-loader/pull/9#issuecomment-413374643, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPqj9EiZ6vg1YUCjA5r-xC7rL_2QLPAks5uRLKGgaJpZM4V0i_r .

jjwallace commented 6 years ago

Cool, seems the Json's are loading great with the code. I can clean up everything and do a new PR if needed. Should I add Json loading to the demo?

mattcolman commented 6 years ago

yeah just clean it up and I'll merge it in. No need to add the demo.