search

mattconnolly / ZipArchive

zip archive processing for Cocoa - iPhone and OS X
http://code.google.com/p/ziparchive/
MIT License
840 stars 260 forks source link

Retain Cycle cause by strong reference to delegate #74

Open raphaeloliveira opened 8 years ago

raphaeloliveira commented 8 years ago

Hey Matt, maybe I'm wrong but I think you should not have a strong reference to your delegate with the risk of causing a retain cycle.

https://github.com/mattconnolly/ZipArchive/blob/master/ZipArchive.h#L89

mattconnolly commented 8 years ago

I think you’re right. I haven’t looked at this project for a while now. Feel free to send a pull request.

-Matt

On 17 Dec 2015, at 7:26 PM, Raphael Oliveira notifications@github.com wrote:

Hey Matt, maybe I'm wrong but I think you should not have a strong reference to your delegate with the risk of causing a retain cycle

https://githubcom/mattconnolly/ZipArchive/blob/master/ZipArchiveh#L89

— Reply to this email directly or view it on GitHub https://github.com/mattconnolly/ZipArchive/issues/74.

hemang-azilen commented 8 years ago

I'm getting following error (https://github.com/mattconnolly/ZipArchive/issues/66) when installing ZipArchive manually. Can you suggest me how to integrate it properly? I couldn't find any steps to do so. @mattconnolly @raphaeloliveira