search

mattcurrie / mgbdis

Game Boy ROM disassembler with RGBDS compatible output
MIT License
248 stars 38 forks source link

Add an `--uppercase-hex` command-line option #1

Closed kemenaran closed 6 years ago

kemenaran commented 6 years ago

Hi! I recently hacked a bit into mgbdis; thanks for this project! This is exactly the disassembler I was looking for, it definitely suited what I wanted (adding disassembly for more banks in the Zelda DX disassembly, and I found the code base quite easy to work this.

I made a few modifications and additions that I'd like to submit upstream (like refactored the way symbols are handled); but first here are a few stylistic options and changes that I think could be useful.

So here come a bunch of PRs with different suggestions and options; feel free to reject them if they don't feel suitable to you.

Description

By default hexadecimal numbers use lowercase characters ($df01).

This PR allows to pass the --uppercase-hex flag to format hexadecimal numbers using uppercase characters instead ($DF01).

mattcurrie commented 6 years ago

Hi, glad you found it useful :) Thanks for sending through the pull requests - any improvements to the project are definitely welcome! I'll have a look through them now.