mattdavis90 / node-red-contrib-tado-client

Tado web API client node for Node Red
MIT License
20 stars 16 forks source link

Set GeoTracking not working #24

Closed derekoharrow closed 3 years ago

derekoharrow commented 3 years ago

Hi Using v0.8.1 and trying to turn off/on Geotracking for a mobile device. When I add the Tado node and select the "Set Geo Tracking for a mobile device" option, I cannot specify which deviceId or homeId in the panel, and no matter what I try I cannot change Geo Tracking from Enabled to Disabled - it just reverts back to Enabled all the time. Any ideas? Thanks

mattdavis90 commented 3 years ago

Thanks for reporting this. Looks like a bug. A fix is in progress and will be in the v0.9.0 release. Thanks

derekoharrow commented 3 years ago

Just tried installing v0.9.0 and I just get this in the logs:

20 Oct 09:22:29 - [info] Waiting for missing types to be registered:
20 Oct 09:22:29 - [info]  - tado-config
20 Oct 09:22:29 - [info]  - tado

And my flows are stopped due to these nodes missing...

derekoharrow commented 3 years ago

I also saw this in the Node RED startup log:

20 Oct 09:33:00 - [info] Node-RED version: v1.2.2
20 Oct 09:33:00 - [info] Node.js  version: v10.22.1
20 Oct 09:33:00 - [info] Linux 5.0.0-38-generic x64 LE
20 Oct 09:33:01 - [info] Loading palette nodes
20 Oct 09:33:03 - [info] Dashboard version 2.23.4 started at /ui
20 Oct 09:33:04 - [warn] ------------------------------------------------------
20 Oct 09:33:04 - [warn] [node-red-contrib-tado-client/tado] SyntaxError: Invalid or unexpected token
20 Oct 09:33:04 - [warn] ------------------------------------------------------
20 Oct 09:33:04 - [info] Settings file  : /data/settings.js
20 Oct 09:33:04 - [info] Context store  : 'default' [module=memory]
20 Oct 09:33:04 - [info] User directory : /data
20 Oct 09:33:04 - [warn] Projects disabled : editorTheme.projects.enabled=false
20 Oct 09:33:04 - [info] Flows file     : /data/flows.json
20 Oct 09:33:04 - [info] Server now running at http://127.0.0.1:1880/
20 Oct 09:33:04 - [warn]
mattdavis90 commented 3 years ago

Hi, I think that is related to the node version you're running. The update to v0.9.0 requires at least node version 12 due to the async function syntax. Are you able to update and see if the issue persists. Apologies for the inconvenience

derekoharrow commented 3 years ago

Hmmm. That could be it - thanks. Just need to figure out how to upgrade it now - I'm running the official node-red docker image (nodered/node-red:latest)

derekoharrow commented 3 years ago

Got it! (nodered/node-red:latest-12) - testing now. Thanks!

derekoharrow commented 3 years ago

Brilliant - works now! Thank you.