search

mattdavis90 / node-red-contrib-tado-client

Tado web API client node for Node Red
MIT License
23 stars 16 forks source link

This method of setting zone overlays will soon be deprecated, please use setZoneOverlays #61

Closed Jleagle closed 9 months ago

Jleagle commented 10 months ago

Hi, i am getting This method of setting zone overlays will soon be deprecated, please use setZoneOverlays in the logs when i call 'Set a Zone\'s overlay'

https://i.imgur.com/TIDc6uJ.png

Seems like it should already be being called.

Thanks.

Jleagle commented 10 months ago

I resaved a node and it started giving this error:

https://i.imgur.com/QOJoVJh.png

mattdavis90 commented 10 months ago

Hi,

I can't see either of your images. You should be able to upload directly into the comment box on GitHub and don't need to use a 3rd party host.

The message is only a warning. I fully intended to migrate this client over to using the newer API call but haven't found time. It is fully safe to ignore.

Is this causing you any problems other than the log message?

mattdavis90 commented 10 months ago

To clarify, the warning comes from the underlying node library (which I also author) and not from Tado themselves. The singular API in the underlying library isn't really being updated anymore and I didn't want to duplicate the business logic between the singular and plural calls so chose to deprecate the singular ones. Implementing the UI elements in NodeRed to enable multiple zone overrides became very time consuming and complicated.

Jleagle commented 10 months ago

Not causing issues other than in the logs, sounds fine, cheers!

mattdavis90 commented 10 months ago

Ok. In that case I'll close the issue. Apologies for any inconvenience caused. Thanks

Jleagle commented 10 months ago

I resaved a node and it started giving this error:

https://i.imgur.com/QOJoVJh.png

Hi, i forgot about the above issue, re-uploaded the images so you can see them. If you like i can create a seperate issue.

After updating to the latest version, the nodes seemed okay at first but after going into them and saving the node, i get this error.

QOJoVJh_d

TIDc6uJ_d

mattdavis90 commented 10 months ago

Hi, Sorry, I didn't realise there were two issues. I think I've seen that before. There was a bug in one of the releases that didn't quite clear out any default values correctly. I think updating to the latest release should work. If it doesn't then let me know and I'll do some more digging. Alternatively, you can edit the node, temporarily pick a call that displays the Tariff box, type a 0 in it, then switch everything back to the way you had it before, then save. Hopefully updating fixes it though and you don't have to do that faff for each node. NodeRed doesn't have a nice built-in way for nodes to upgrade their internal config.

Jleagle commented 10 months ago

Alternatively, you can edit the node, temporarily pick a call that displays the Tariff box, type a 0 in it, then switch everything back to the way you had it before, then save.

This fixed it, thanks. This happened using the latest version.

mattdavis90 commented 10 months ago

Glad it's fixed. I'll double check the released version and how I'm handling the config migrations. I'll leave this open to track. Thanks