mattdesl / budo

:clapper: a dev server for rapid prototyping
MIT License
2.18k stars 106 forks source link

Node.js v6: `v8::ObjectTemplate::Set() with non-primitive values is deprecated` #153

Closed neurosnap closed 8 years ago

neurosnap commented 8 years ago

After upgrading to node v6.0 I'm getting the error in the title. The source appears to be from the chokidar dependency.

paulmillr/chokidar#473

./node_modules/.bin/budo -d ./public -v src/app.js:dist/appBundle.js -p 8000 -- --ignore-missing \
        -t babelify \
        -t envify \
        -p browserify-hmr 

(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x537895c9fa9 <JS Object>#0#
    1: .node [module.js:568] [pc=0x174fa8a304a4] (this=0x1873402cf541 <an Object with map 0x1b9190c17be1>#1#,module=0x5e4563b0349 <a Module with map 0x1b9190c181b9>#2#,filename=0x5e4563b0321 <String[101]: /Users/erock/notion/notion-web/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    2: load [module.js:456] [pc=0x174fa8938e72] (this=0x5e4563b0349 <a Module with map 0x1b9190c181b9>#2#,filename=0x5e4563b0321 <String[101]: /Users/erock/notion/notion-web/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    3: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x174fa893899d] (this=0x53789504189 <undefined>,module=0x5e4563b0349 <a Module with map 0x1b9190c181b9>#2#,filename=0x5e4563b0321 <String[101]: /Users/erock/notion/notion-web/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    4: _load [module.js:~381] [pc=0x174fa8463] [pc=0x174fa8985fab] (this=0x5e456119049 <a Module with map 0x1b9190c181b9>#20#,path=0xa9560771e59 <String[8]: watchify>)
   38: require(aka require) [internal/module.js:20] [pc=0x174fa8942226] (this=0x53789504189 <undefined>,path=0xa9560771e59 <String[8]: watchify>)
   39: /* anonymous */ [/Users/erock/notion/notion-web/node_modules/watchify-middleware/lib/bundler.js:1] [pc=0x174fa89d27e7] (this=0x5e456119209 <an Object with map 0x3b75d0607b71>#21#,exports=0x5e456119209 <an Object with map 0x3b75d0607b71>#21#,require=0x5e45611dc11 <JS Function require (SharedFunctionInfo 0x187340258b29)>#22#,module=0x5e456119049 <a Module with map 0x1b9190c181b9>#20#,__filename=0x5e456119021 <String[78]: /Users/erock/notion/notion-web/node_modules/watchify-middleware/lib/bundler.js>,__dirname=0x5e45611dba9 <String[67]: /Users/erock/notion/notion-web/node_modules/watchify-middleware/lib>)
   40: _compile [module.js:541] [pc=0x174fa8941944] (this=0x5e456119049 <a Module with map 0x1b9190c181b9>#20#,content=0x5e45611c089873402cf5c1 <JS Function Module (SharedFunctionInfo 0x187340228c39)>#3#)
   86: startup(aka startup) [node.js:159] [pc=0x174fa884085e] (this=0x53789504189 <undefined>)
   87: /* anonymous */(aka /* anonymous */) [node.js:444] [pc=0x174fa883e4f2] (this=0x53789504101 <null>,process=0x537895e5969 <a process with map 0x3b75d0611469>#42#)
=====================

==== C stack trace ===============================

 1: v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)
 2: fse::FSEvents::Initialize(v8::Local<v8::Object>)
 3: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&)
 4: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
 5: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>)
 6: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)
 7: 0x174fa880961b
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x537895c9fa9 <JS Object>#0#
    1: .node [module.js:568] [pc=0x174fa8a304a4] (this=0x1873402cf541 <an Object with map 0x1b9190c17be1>#1#,module=0x5e4563b0349 <a Module with map 0x1b9190c181b9>#2#,filename=0x5e4563b0321 <String[101]: /Users/erock/notion/notion-web/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    2: load [module.js:456] [pc=0x174fa8938e72] (this=0x5e4563b0349 <a Module with map 0x1b9190c181b9>#2#,filename=0x5e4563b0321 <String[101]: /Users/erock/notion/notion-web/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    3: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x174fa893899d] (this=0x53789504189 <undefined>,module=0x5e4563b0349 <a Module with map 0x1b9190c181b9>#2#,filename=0x5e4563b0321 <String[101]: /Users/erock/notion/notion-web/node_modules/fsevents/lib/binding/Release/node-v48-darwin-x64/fse.node>)
    4: _load [module.js:~381] [pc=0x174fa88a9 <an Object with map 0x3b75d0607b71>#32#,require=0x1873402cf699 <JS Function require (SharedFunctionInfo 0x187340258b29)>#33#,module=0x1873402cf609 <a Module with map 0x1b9190c181b9>#31#,__filename=0x1873402cf851 <String[60]: /Users/erock/notion/notion-web/node_modules/budo/lib/budo.js>,__dirname=0x1873402cf829 <String[52]: /Users/erock/notion/notion-web/node_modules/budo/lib>)
   64: _compile [module.js:541] [pc=0x174fa8941944] (this=0x1873402cf609 <a Module with map 0x1b9190c181b9>#31#,content=0x1873402d1849 <Very long string[7911]>#34#,filename=0x1873402cf851 <String[60]: /Users/erock/notion/notion-web/node_modules/budo/lib/budo.js>)
   65: .js [module.js:550] [pc=0x174fa893a46b] (this=0x1873402cf541 <an Object with map 0x1b9190c17be1>#1#,module=0x1873402cf609 <a Module with map 0x1b9190c181b9>#31#,filename=0x1873402cf851 <String[60]: /Users/erock/notion/notion-web/node_modules/budo/lib/budo.js>)
   66: load [module.js:456] [pc=0x174fa8938e72] (this=0x1873402cf609 <a Module with map 0x1b9190c181b9>#3 1: v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)
 2: fse::FSEvents::Initialize(v8::Local<v8::Object>)
 3: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&)
 4: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
 5: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>)
 6: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)
 7: 0x174fa880961b
yoshuawuyts commented 8 years ago

@neurosnap did you update your native dependencies? e.g. remove node_modules and npm install OR run npm rebuild. Cheers!

quantizor commented 8 years ago

I don't get this error and I'm running 6.2. +1 to @yoshuawuyts's suggestion.

yoshuawuyts commented 8 years ago

Given the lack of updates on this issue I'm going to assume it's been resolved - feel free to report back if it's not and we can reopen. Cheers!