search

mattdesl / dom-css

fast dom CSS styling
MIT License
152 stars 13 forks source link

Add discrete string handling #13

Closed dy closed 7 years ago

dy commented 8 years ago

Hi @mattdesl! Here is per-property string handling, as discussed in #12. It should also take care of prefixing properties.

hollowdoor commented 8 years ago

@dfcreative Wow cool! You did it. Simple string splitting, and slicing for a parser too. Should work nicely.

dy commented 7 years ago

@mattdesl is there something making you doubt about it?

mattdesl commented 7 years ago

Hmm yes I've been wondering if string-based stuff is just totally out of scope of this module. I think it should probably be removed and moved into a new module.

Adding string-based stuff here will start to introduce yet more scope this module has to handle (e.g. comments). The behaviour might also be unexpected, since some users would expect it to auto-prefix, while others might expect it to set cssText without any changes.

I think it's best just to maintain a small scope and revert the other changes... Sorry mate! 🍻