Closed kewah closed 9 years ago
Cool, cheers! :+1:
It's a bit confusing though since the outcome depends on the previous state. Sometimes it will return the computed value, and other times it just returns the value that was last set (eg width: '20%'
). There's also lots of edge cases that should probably handled for getting a computed value.
An idea would be to make this dom-css
module just return the inline style, and let another module handle the computed style.
Another nitpick: for parity it would be good to include a set
name to the export, so the exports could look like this:
function set() {
....
}
module.exports = set
module.exports.set = set
module.exports.get = function(element, properties) {
...
}
I agree :+1: commit amended
published @1.1.0
thanks!
Hey,
I have added the
.get()
function that returns the computed value the the element.When I set a property with
dom-css
I expect to be able to get its value (or another one). Especially when I set a prefixed property. Otherwise I need use another module to get the prefixed property and useelement.style[]
or.getComputedStyle()
.IMO it makes sense to be able to set and get elements' properties in the same module.
I tried to respect your style guide, let me know if I've missed something :)
Thanks.