mattdesl / mp4-h264

[project suspended] MP4 + H264 encoding for the browser with WASM
MIT License
223 stars 12 forks source link

Safari support #6

Open no-1ne opened 3 years ago

no-1ne commented 3 years ago

Thank you for sharing your work of adding optimisations over original library

Safari is yet to support offscreencanvas due to which the demo fails saying “No support for OffscreenCanvas on this browser”

https://mattdesl.github.io/mp4-wasm-encoder/

The demo original of repo worked in safari... https://trevorsundberg.github.io/h264-mp4-encoder/

I hope that can be resolved using this polyfill https://github.com/ai/offscreen-canvas

mattdesl commented 3 years ago

Thanks! The demo in this repo should work with Safari (at least works fine on my iOS), see below:

https://codepen.io/mattdesl/full/MWjeJMg

(the other repo/demo of mine you linked is outdated, this ‘mp4-h264’ module should be seen as latest version)

Some of the demos in the examples folder may include other features like worker modules / offscreen canvas that doesn’t work, though.

mattdesl commented 3 years ago

Actually, I realize you might be asking to bring that demo over to this latest module, and fix up Safari, in which case yep I definitely should do that!