search

mattdesl / three-line-2d

lines expanded in a vertex shader
MIT License
235 stars 34 forks source link

r75 #1

Closed Ramshackle-Jamathon closed 8 years ago

Ramshackle-Jamathon commented 8 years ago

don't let this great module get outdated : )

Its been really helpful for making lines render consistantly across OSX and Windows

mattdesl commented 8 years ago

This looks awesome! Have you noticed the npm test demo is half size? I think it may just be due to the three-orbit-viewer (so unrelated to your PR).

I can review more carefully on Monday or Tuesday.

Ramshackle-Jamathon commented 8 years ago

No need to rush with the review : )

I didn't notice the size difference ¯(ツ)/¯ (I see it now though)

mattdesl commented 8 years ago

I went through and cleaned this repo up to match some of my new JS practices (new linter, some different ways of building ThreeJS demos across versions, etc).

Thanks again! Let me know if the new version has any issues.

Note: This should still work as before, where you need a ShaderMaterial for the basic shader (not RawShaderMaterial).