search

mattdibi / redox-w-firmware

Firmware for nordic MCUs used in the Redox wireless keyboard
MIT License
77 stars 42 forks source link

Key roll over broken when building keyboard firmware #5

Closed LucidityCrash closed 5 years ago

LucidityCrash commented 5 years ago

With the work I've been doing trying to port to SDK v12 I noticed that the key roll over wasn't working correctly with my builds, so I reverted to the precompiled ones in the repo and 6KRO and NKRO work as expected. If I then build the keyboard firmware (using the master branch with no changes) the issue with key roll over is back so it isn't the code changes I've been testing only alternate keys seem to register.

as an example using the matrix debug and hid listener I see this on the right hand using the precompiled hex (I'm pressing down 5 keys one after the other): r/c 0123456789ABCDEF 00: 0000000000000000 01: 0000000000001000 02: 0000000000000000 03: 0000000000000000 04: 0000000000000000

r/c 0123456789ABCDEF 00: 0000000000000000 01: 0000000000011000 02: 0000000000000000 03: 0000000000000000 04: 0000000000000000

r/c 0123456789ABCDEF 00: 0000000000000000 01: 0000000000111000 02: 0000000000000000 03: 0000000000000000 04: 0000000000000000

r/c 0123456789ABCDEF 00: 0000000000000000 01: 0000000001111000 02: 0000000000000000 03: 0000000000000000 04: 0000000000000000

r/c 0123456789ABCDEF 00: 0000000000000000 01: 0000000011111000 02: 0000000000000000 03: 0000000000000000 04: 0000000000000000

On the Left Hand using my build hex (doing the same pressing down of 5 keys one at a time): r/c 0123456789ABCDEF 00: 0000000000000000 01: 0100000000000000 02: 0000000000000000 03: 0000000000000000 04: 0000000000000000

r/c 0123456789ABCDEF 00: 0000000000000000 01: 0101000000000000 02: 0000000000000000 03: 0000000000000000 04: 0000000000000000

r/c 0123456789ABCDEF 00: 0000000000000000 01: 0101010000000000 02: 0000000000000000 03: 0000000000000000 04: 0000000000000000

I'm attaching my resulting hex in case it helps. nrf51822_xxac.hex.gz

I'll go about building a ubuntu 16.04 VM and try building in that and report back.

LucidityCrash commented 5 years ago

Yep ... that fixed it, need to build in 16.04.