search

mattdibi / yampad

Feature-packed open source macropad
MIT License
326 stars 53 forks source link

Multiple key presses not registering - debouncing issue? #11

Open Daveyr opened 3 years ago

Daveyr commented 3 years ago

I have successfully built a yampad and all keys are working, including keys across multiple layers. However, when I rapidly press any of the keys the second and subsequent key presses are not being registered.

Is this a firmware issue or a hardware one? My instinct is that this is a debouncing setting to avoid multiple key presses when you intend only one. However, the current setting means that the numpad is not very usable.

mattdibi commented 3 years ago

Hi,

have you tried changing the debouncing delay in QMK? Does it improve?

Daveyr commented 3 years ago

Good call, this was the reason in the end. I used a specific debouncing method (sym_eager_pk) and changed debounce to 2 ms from 5 ms. Now the numpad is a dream to type on. All the firmware files are in https://github.com/Daveyr/yampad. I can issue a pull request if useful?

mattdibi commented 3 years ago

Glad to hear that. I would happily accept a PR on my qmk firmware fork if you are so inclined.

I've also noticed you opened a PR on the official QMK repo for the yampad. I think once merged it'll make more sense to make that the official configuration for the yampad and remove the references in the documentation pointing to my fork. WDYT?

Unfortunately lately I'm really busy and can only respond issues on weekends. Sorry if I take so long to answer.