search

matte-ek / BanchoMultiplayerBot

Auto host rotation multiplayer bot for osu! written in C#
GNU General Public License v3.0
24 stars 5 forks source link

!mp settings sometimes ignored after match finish #1

Closed matte-ek closed 1 year ago

matte-ek commented 1 year ago

On rare occasions after a match finished, BanchoBot does not reply to !mp settings , which causes the host rotation and such to fail. The OnPrivateMessageSent event gets invoked, which means it should have sent the message, as seen here, so I don't think BanchoSharp is to blame here.

matte-ek commented 1 year ago

Starting to think that this is just some rate limiting thing going on, even though the bot should be within the limits, gonna try dialing down the max amount of burst messages and see if it continues to happen.

matte-ek commented 1 year ago

Possibly fixed with https://github.com/matte-ek/BanchoMultiplayerBot/commit/26ef09755212825300022a5ec1342036b80bfb4b . This takes a long time to test since I have no idea when it happens. This is still stupid even if this were to decrease the amount of times this happens. I don't think it has anything to do with rate-limting from Bancho either, but at the same time no messages should be dropped due to the nature of TCP.