(Resolved) Possibility for changing Port for Web

matte-ek / BanchoMultiplayerBot

Auto host rotation multiplayer bot for osu! written in C#

GNU General Public License v3.0

25 stars 6 forks source link

(Resolved) Possibility for changing Port for Web #5

Closed KannaDev closed 1 year ago

KannaDev commented 1 year ago

So, something which can be added to appsettings.json is the ability to change the port which the Web GUI Binds too, as port 5000 is a port that many services use, it causes trouble for people running multiple services.

matte-ek commented 1 year ago

Hey, adding the following to your appsettings.json should do the trick:

"Urls": "http://localhost:5002"

Pretty sure this is also possible via environment variables using ASPNETCORE_URLS=http://localhost:5002/

KannaDev commented 1 year ago

Okay! Thanks for that, one issue I faced is that when logging in, it then brings up osu's OAUTH, which after approving, redirects to localhost rather than the domain, which is behind a reverse proxy.

matte-ek commented 1 year ago

Not sure what you are refering to here, as my bot does not (currently) use osu's OAuth anywhere. I've planned to replace the current authentication system to it, but haven't gotten around to doing it yet.

KannaDev commented 1 year ago

https://upload.kannadev.com/u/msedge_QQAA2fF4Kz.gif

KannaDev commented 1 year ago

msedge_QQAA2fF4Kz

matte-ek commented 1 year ago

I'm so sorry, I just realized I might have released a build (v1.4.0) where I was experimenting with OAuth authentication within the bot, which I did around the time I released that. No clue how I managed to forget to remove that but here we are, my bad. The newest release I did today should have this fixed and should be behaving as normal.

KannaDev commented 1 year ago

No need to apologise, mistakes happen. Looking forward to it if it ends up releasing. Thanks for the quick response!

KannaDev commented 1 year ago

The WebUI now works perfectly fine, though I am unable to connect to Bancho with neither new or old api keys. And no logs. Neither on my VPS or PC are able to get the functionality to work

KannaDev commented 1 year ago

Using the following it is able to connect, and make lobbies. But not with your software.

matte-ek commented 1 year ago

I could reproduce, and to be honest with you I have no idea how I managed to upload a borked build twice.... I really need to reconsider this workflow (as I don't personally use the github releases), with maybe Github Actions testing and then publishing the builds, so they actually work.

I replaced the binary in the newest release, and personally tested quickly on my machine to make sure they work properly, lol. If you need any further support feel free to contact me on Discord "matte # 4873". Sorry for wasting your time.

KannaDev commented 1 year ago

It's all fine, and you're not wasting my time in any way at all, these things happen and i've been in the same situation as this, instead of treating it as a negative experience, it's a way to learn and make sure things like this don't happen. GitHub actions could be a good way at testing. And I will now test the newest release. And if I do, I'll let you know.

KannaDev commented 1 year ago

Closing this issue as all is now resolved, looking forward to see future updates, and love the project!