search

matteo-ronchetti / aws-lambda-power-tuning-ui

UI to visualize the results of https://github.com/alexcasalboni/aws-lambda-power-tuning
Apache License 2.0
98 stars 18 forks source link

Make colors and style configurable #6

Open alexcasalboni opened 4 years ago

alexcasalboni commented 4 years ago

Not a hard requirement, but this would make the visualization tool more flexible.

For this, I'd suggest using query string parameters instead of the hash. Maybe we could even use query string parameters for everything.

Something like:

URL?power=<encoded>&time=<encoded>&cost=<encoded>&colors=...&style=...

This way, it's also easier to add new customizations in the future.

matteo-ronchetti commented 4 years ago

The hash is currently used because it is not sent to the server, therefore is a guarantee of data privacy. Of course color and styles are definitely not sensitive and can be specified using query string parameters

alexcasalboni commented 4 years ago

Makes sense, good thinking!

On Thu, 3 Oct 2019 at 20:49, Matteo Ronchetti notifications@github.com wrote:

The hash is currently used because it is not sent to the server, therefore is a guarantee of data privacy. Of course color and styles are definitely not sensitive and can be specified using query string parameters

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/matteo-ronchetti/aws-lambda-power-tuning-ui/issues/6?email_source=notifications&email_token=AASX75FEFKQVDPW3X2CMYKTQMY5CXA5CNFSM4I5EBDHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAJGKHA#issuecomment-538076444, or mute the thread https://github.com/notifications/unsubscribe-auth/AASX75APNQGF7PNPXO6PDJLQMY5CXANCNFSM4I5EBDHA .

alexcasalboni commented 4 years ago

I'll try to find some time to work on this.

We don't need total customization, but it has come up that even just changing the default colors would be useful sometimes. I'm finding out that the chart interpretation isn't always super clear and even simple things might be misinterpreted (e.g. "red" might be perceived as a "negative" curve).