search

matteocorti / check_ssl_cert

A shell script (that can be used as a Nagios/Icinga plugin) to check an SSL/TLS connection.
GNU General Public License v3.0
368 stars 132 forks source link

Allow underscore in Hostname #323

Closed mookie- closed 3 years ago

mookie- commented 3 years ago

Proposed Changes

This change allows to have a _ in your subdomain. Even if it's not valid, some third-partys give you subdomains with '_' in it and it would be nice if we could also run check_ssl_cert for these.

matteocorti commented 3 years ago

I agree, if these names exist, it makes sense to allow a check. But maybe we should inform (in verbose mode?)

mookie- commented 3 years ago

@matteocorti That's a good idea. I'll also try to create an unit test for using check_ssl_cert with Subdomains including a _ as there was already a commit with a similar topic in another place (https://github.com/matteocorti/check_ssl_cert/commit/bfff06824bb8ac47c37b531c6d60cb12824b8636)

matteocorti commented 3 years ago

Thanks, a test is surely always a good idea

mookie- commented 3 years ago

@matteocorti Somehow I've made a mistake with the commit here. I accidentally added the unkown typo back. :see_no_evil: I think it's the easiest solution if you just commit it yourself again.

matteocorti commented 3 years ago

I fixed it again :-)