search

matteocorti / check_ssl_cert

A shell script (that can be used as a Nagios/Icinga plugin) to check an SSL/TLS connection.
GNU General Public License v3.0
368 stars 132 forks source link

Switch a lack of cert to unknown #357

Closed peternewman closed 2 years ago

peternewman commented 2 years ago

I guess this might be controversial, so maybe it needs an option instead?

matteocorti commented 2 years ago

We could add an option but according to the Development Guidelines "Unknown" should only be used for internal (plugin) issues.

Invalid command line arguments were supplied to the plugin or low-level failures internal to the plugin (such as unable to fork, or open a tcp socket) that prevent it from performing the specified operation. Higher-level errors (such as name resolution errors, socket timeouts, etc) are outside of the control of plugins and should generally NOT be reported as UNKNOWN states.

matteocorti commented 2 years ago

https://nagios-plugins.org/doc/guidelines.html#AEN78

peternewman commented 2 years ago

We could add an option but according to the Development Guidelines "Unknown" should only be used for internal (plugin) issues.

Invalid command line arguments were supplied to the plugin or low-level failures internal to the plugin (such as unable to fork, or open a tcp socket) that prevent it from performing the specified operation. Higher-level errors (such as name resolution errors, socket timeouts, etc) are outside of the control of plugins and should generally NOT be reported as UNKNOWN states.

Ah nice, I'd not found something so clear-cut before. Although I note they don't tell you what state to actually return if e.g. name resolution has failed so whether the certificate is good or not is unknown.

Given that specific example, if you can work out what state it should be instead, maybe this should be changed? https://github.com/matteocorti/check_ssl_cert/blob/5468c14404c4974e2b7b80fa5a0a869a37613078/check_ssl_cert#L3346

peternewman commented 2 years ago

Also I hadn't realised you had tests, that's awesome!