search

matteocorti / check_ssl_cert

A shell script (that can be used as a Nagios/Icinga plugin) to check an SSL/TLS connection.
GNU General Public License v3.0
368 stars 132 forks source link

stray backslashes #435

Closed waja closed 1 year ago

waja commented 1 year ago

In Debian was introduced grep 3.8, which changed it's behaviour cause:

Regular expressions with stray backslashes now cause warnings, as their unspecified behavior can lead to unexpected results. For example, '\a' and 'a' are not always equivalent https://bugs.gnu.org/39678. Similarly, regular expressions or subexpressions that start with a repetition operator now also cause warnings due to their unspecified behavior; for example, *a(+b|{1}c) now has three reasons to warn. The warnings are intended as a transition aid; they are likely to be errors in future releases.

This also affects check_ssl_cert and we got a patch against 2.27. Unfortunately it does not apply cleanly against master. It would be cool to get this fixed, cause it might hit check_ssl_cert sometime in the future (when this grep variant is rolling more and more into production).

Thanks Jan

matteocorti commented 1 year ago

Dear Jan

The issue is known and several stray backslashes were already removed.

I'll take a look

Matteo

matteocorti commented 1 year ago

Dear Jan

I fixed another one but should now be OK

Can you please check with the latest version?

Matteo

matteocorti commented 1 year ago

On Debian 11 I get:

corti@debian check_ssl_cert> lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux 11 (bullseye)
Release:    11
Codename:   bullseye
corti@debian check_ssl_cert> make test 2>&1 | grep -i spur
corti@debian check_ssl_cert>
waja commented 1 year ago

jepp ... should be all fixed. thanks!

matteocorti commented 1 year ago

Thanks anyway for the patch!