matteocorti / check_ssl_cert

A shell script (that can be used as a Nagios/Icinga plugin) to check an SSL/TLS connection.
GNU General Public License v3.0
372 stars 132 forks source link

Options missing arguments shouldn't include the pipe in their UNKNOWN response #516

Closed peternewman closed 2 months ago

peternewman commented 2 months ago

Describe the bug

A clear and concise description of what the bug is.

On Nagios if you've failed to pass in an argument, the check currently ends up in the following state:

Status Information: SSL_CERT UNKNOWN: '-p Performance Data: --port' requires an argument

To Reproduce

Steps to reproduce the behavior. check_ssl_cert -H localhost -p

Expected behavior

A clear and concise description of what you expected to happen.

This output, or something similar (e.g. "or" or "/" would fix it): SSL_CERT UNKNOWN: '-p --port' requires an argument

System (please complete the following information):

Additional context/output

Add any other context or output (e.g., from check_ssl_cert -d -v) about the problem here.

Looks to be this: https://github.com/matteocorti/check_ssl_cert/blob/master/check_ssl_cert#L3091

matteocorti commented 2 months ago

Thanks, didn't think about Nagios interpreting the |