search

matteodanelli / MMM-cryptocurrency

A MagicMirror module for crypto currencies value.
MIT License
96 stars 42 forks source link

Does not load on 2.18.0 version of Magic Mirror #107

Closed bma-diy closed 2 years ago

bma-diy commented 2 years ago

I've had this module up and running previously with no issues. I decided to upgrade MM and it does not seem to be compatible with this app. I have also tried doing a fresh install. All other apps work, but this one fails for some reason. Here are the error messages I get:

`pi@magicpi:~/MagicMirror $ npm run start

magicmirror@2.18.0 start DISPLAY="${DISPLAY:=:0}" ./node_modules/.bin/electron js/electron.js

[02.01.2022 14:56.07.011] [LOG] Starting MagicMirror: v2.18.0 [02.01.2022 14:56.07.024] [LOG] Loading config ... [02.01.2022 14:56.07.040] [LOG] Loading module helpers ... [02.01.2022 14:56.07.046] [LOG] No helper found for module: alert. [02.01.2022 14:56.07.094] [LOG] Initializing new module helper ... [02.01.2022 14:56.07.096] [LOG] Module helper loaded: updatenotification [02.01.2022 14:56.07.101] [LOG] No helper found for module: clock. [02.01.2022 14:56.07.679] [LOG] Initializing new module helper ... [02.01.2022 14:56.07.681] [LOG] Module helper loaded: calendar [02.01.2022 14:56.07.692] [ERROR] WARNING! Could not load config file. Starting with default configuration. Error found: Error: Cannot find module 'request' Require stack:

`

ivanxcc commented 2 years ago

I have the same problem after the latest update.

jbrodie commented 2 years ago

Good thing I found this. I don't know what error is showing as I am not on the console for the mirror but as soon as I add in this module the mirror fails to load.

schlomm commented 2 years ago

Same here

matteodanelli commented 2 years ago

Can you try to launch "npm install" inside the module folder to see if it resolves?

bma-diy commented 2 years ago

I ran npm install and still have issues

On Tue, Jan 4, 2022 at 7:36 AM Matteo @.***> wrote:

Can you try to launch "npm install" inside the module folder to see if it resolves?

— Reply to this email directly, view it on GitHub https://github.com/matteodanelli/MMM-cryptocurrency/issues/107#issuecomment-1004817930, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKIOE5G57K5N4DU6QIDCVK3UULZWXANCNFSM5LEB6WJQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- Sent from my iPhone

matteodanelli commented 2 years ago

Please checkout latest release. I removed request andd now it should work with latest MM. Let me know

jbrodie commented 2 years ago

Seemed to have done the trick, thanks for the quick response.

bma-diy commented 2 years ago

Yes it works now. Thanks for solving this so fast.

On Tue, Jan 4, 2022 at 2:44 PM Jay Brodie @.***> wrote:

Seemed to have done the trick, thanks for the quick response.

— Reply to this email directly, view it on GitHub https://github.com/matteodanelli/MMM-cryptocurrency/issues/107#issuecomment-1005157271, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKIOE5FLAJVQXGFATCRXJRLUUNL4VANCNFSM5LEB6WJQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- Sent from my iPhone