matteodem / meteor-easy-search

Easy-to-use search for Meteor with Blaze Components
MIT License
438 stars 68 forks source link

[DOC] Minimongo supporting of transform #532

Closed ilan-schemoul closed 7 years ago

ilan-schemoul commented 7 years ago

Fortunately, and unlike to what the doc states, Minimongo does support transform property (I tested it). I hope I could directly make a PR to update doc but it doesn't seem open source.

matteodem commented 7 years ago

Good stuff, the docs which you are referring are here https://github.com/matteodem/meteor-easy-search/blob/gh-pages/docs/engines.md.

ilan-schemoul commented 7 years ago

Damn you're even more reactive than Meteor.

ilan-schemoul commented 7 years ago

So I'll PR. EDIT : hmm finally I'm not sure because my Windows will once again mess with your folder because it doesn't support : making pointless commits.

matteodem commented 7 years ago

Haha I was just randomly having a look at another PR

(if you feel really lucky I'd gladly appreciate some help on our docs labeled tasks, maybe simple ones like https://github.com/matteodem/meteor-easy-search/issues/526 would already be of great help.)

ilan-schemoul commented 7 years ago

But I'll mess with your folder because my OS doesn't support : in folder. You didn't want of my previous PR because of that and I don't know workaround.

matteodem commented 7 years ago

The branch gh-pages does not have any semicolons, shouldn't break anything

ilan-schemoul commented 7 years ago

Great I'll give it a go when I could then.

ilan-schemoul commented 7 years ago

@matteodem you're right I should participate on the project on what you point out, every single dev who use and appreciate an open-source project should try to PR as much as possible as it's the price (and a pleasure) to pay when you use a free tool, and so every devs can both give and receive amelioration of code. But I really don't have much time these days. I hope I'll come back to your package when I could.

matteodem commented 7 years ago

Thanks a lot for your contribution 😄