search

matteodf / html-to-slack

A module to convert HTML strings to Slack blocks
GNU General Public License v3.0
6 stars 1 forks source link

feat (web) - Fallback to plain-text for `u` tags #6

Closed tauseefk closed 1 month ago

tauseefk commented 1 month ago

feat (web) - Fallback to plain-text for u tags

This updates the parser to return plain text instead of ignoring u tags.

Context

The unsupported tag test hints that the goal of the library is to not support tags unsupported by Slack. And underline is not supported by Slack which is probably why it wasn't included. IMO it would be better to fallback to plain-text for HTML tags that are very common as the Slack conversions look incomplete.

tauseefk commented 1 month ago

@matteodf not able to request a review so tagging

matteodf commented 1 month ago

Hi @tauseefk ,

sorry for the delay and thanks for your pull request! It makes a lot of sense to me that u tags have a fallback to plain text. I have done the merge!

Thanks for your contribution! If you have any other suggestions, please feel free to open new PRs or issues!