Added ability to set query string parameters for #9

matteofigus / api-benchmark

A node.js tool to benchmark APIs

MIT License

311 stars 35 forks source link

Added ability to set query string parameters for #9 #17

Closed dmyers closed 9 years ago

dmyers commented 9 years ago

The ability to set the query string is built into Superagent. We just needed to update the request agent to support passing them to it and add displaying the query in the report. http://visionmedia.github.io/superagent/#get-requests

@matteofigus What do you think?

dmyers commented 9 years ago

@matteofigus Are those tests failing due to me or do you know if they are false positives? I tested this and it worked perfectly and showed correctly in the report.

matteofigus commented 9 years ago

Hello, thanks for the Pull Request! The tests seem to fail for different reasons, so I'll try to investigate as soon as I can.

Matteo

dmyers commented 9 years ago

Alright that sounds good, I wasn't sure since I had tested on my local machine and it worked perfectly. :+1: