matteofigus / npm-stats-www

A website showing npm modules metrics
http://www.npm-stats.com
111 stars 17 forks source link

Workaround for repos with dots in their names. Fixes #1 #2

Closed pluma closed 10 years ago

pluma commented 10 years ago

This should solve the dot issue. Renaming the div is a bit of a hack, but it's easier than making sure everything else (including third-party plugins) remembers to escape dots in the id when creating a query from an element id.

I've added a loop to make sure the new divId is unique (which is neccessary because a user could reasonably have the same repo on his account twice, once with a dash and once with a dot).

matteofigus commented 10 years ago

Thank you, looks good to me :+1: