search

matteogobbi / MGSpotyViewController

Beautiful viewController with a tableView and amazing effects like a viewController in the Spotify app.
MIT License
1.02k stars 106 forks source link

Support for UITableViewStyleGrouped and changing mainImage #8

Closed insanj closed 9 years ago

insanj commented 10 years ago

At the moment, MGSpotyViewController doesn't handle UITableViewStyleGrouped very well, allowing the backing view to be visible alongside the overView behind the cells (especially when scrolling). Also, there's no way to properly change the mainImageView image after its initial setup (the image backing is not visible from other classes). This means there's no way to "lazy load" imagery and prevent lengthy delays if the main image needs to be pulled from the server. Love the utility besides these drawbacks! I'm sure they'd be solved by simply using header-declared properties instead of ivars.

Let me know if you have any plans to resolve these issues, or if you wouldn't mind me submitting a pull request for them myself :)

matteogobbi commented 10 years ago

Hi @insanj, in the last commit there is the support to change the mainImage during the use. I forgot to update the pod spec :palm_tree: :)

For the UITableViewStyleGrouped support and any other useful thing to make this component awesome, every one is VERY WELCOMED to submit pull requests.

Cheers and enjoy ;)

fvisticot commented 10 years ago

Can you please update the pod.. still 0.0.1

matteogobbi commented 9 years ago

Done