search

matteolucchini1 / nDspec

A modular X-ray spectral-timing astronomy modelling package
MIT License
2 stars 0 forks source link

Addition of set_exposure_time and ignore_channels #18

Open bjricketts opened 2 weeks ago

bjricketts commented 2 weeks ago

This branch has implemented the set_exposure_time method to Response.py to set exposure times for a response for the common scenario when ARF and RMF files don't have an exposure time and they are instead contained within the spectrum file.

It has also implemented ignore_channels to Response.py which allows the user to specify both channel indexes as well as ranges of energies to ignore. Currently, no specific updates to plotting capabilities have been made so this may cause current plotting functions to break when using response matrices made using this method.

Documentation also needs to be written up for these two specific methods.

bjricketts commented 4 days ago

This is definitely not working as intended - I recommend rejecting this pull request until I've sorted this out.

bjricketts commented 4 days ago

Made some fixes such that ignoring energy channels will now work as expected (rather than erroring due to poor logic in variable checks). Ready for review once again.