#28 Added git stash support

matteosister / GitElephant

An abstraction layer for git written in PHP

GNU Lesser General Public License v3.0

613 stars 74 forks source link

#28 Added git stash support #128

Closed kirkmadera closed 6 years ago

kirkmadera commented 6 years ago

Adds support for git stash commands. Resolves #28

kirkmadera commented 6 years ago

Errors in TravisCI are not related to the code changes in this PR.

matteosister commented 6 years ago

awesome thanks! I'll merge and release asap.

kirkmadera commented 6 years ago

I noticed that addCommandSubject() has a string typehint, but the underlying code also deals with arrays and objects. This generates this error in Scruitnizer that can only be fixed by changing the typehint. I didn't want to do that as part of this PR.

matteosister commented 6 years ago

I'll fix it on master, Thanks!

matteosister commented 6 years ago

I had to revert everything, there are many problems with old php version like:

using (Foo::bar($this))->method()
the short array syntax

and also there is a function named list, which is a reserved word

matteosister commented 6 years ago

@kirkmadera if you want to open a new pull request I'll be happy to review it.

kirkmadera commented 6 years ago

I moved it over into my namespace so it's a new pull request. Please see https://github.com/matteosister/GitElephant/pull/132.

I switched my PHPStorm to PHP 5.3 and resolved all notices. I went a little beyond the scope of this issue, but only in documentation. Hope that's ok.