search

matteosister / GitElephant

An abstraction layer for git written in PHP
GNU Lesser General Public License v3.0
613 stars 74 forks source link

Restrict installation to PHP versions < 7.2.0 #130

Closed bnock closed 6 years ago

bnock commented 6 years ago

This change should go into a 1.1.3 release.

bnock commented 6 years ago

This next change should go into a 1.2.0 release.

franzliedke commented 6 years ago

Hmm... won't this mean that people installing GitElephant on PHP 7.2 will just get one of the previous versions? Or is that not a problem once the new, compatible version, is released?

franzliedke commented 6 years ago

Wait, never mind. You haven't changed composer.json.

Releasing this as 1.2.0 would still be breaking (according to SemVer - is that being used here?). Could there be a backwards-compatible way of keeping the old names for all PHP versions before 7.2?

matteosister commented 6 years ago

Thanks for reporting this!!! I'm not using php (and this library) on a daily basis anymore. So I didn't noticed. I think that the best thing to do is releasing a 2.0.0 version with this patch applied. BUT....I want to fix the travis build before that...working on this.

matteosister commented 6 years ago

ok, now the develop branch works with travis-ci, @bradmang18 could you please rebase this branch on develop?

bnock commented 6 years ago

I pulled the changes on develop into my fork. That seemed to run fine.

Then, I added PHP 7.2 to the list of versions for Travis to build against and 7.2 failed. Any ideas?

When I have some time later, I can do a deeper dive into what the issue is.

GenieTim commented 6 years ago

As of today, a version 2.0 was published fixing issues with PHP 7.2. How would you recommend to proceed with this PR, @bradmang18 ?

imunhatep commented 6 years ago

I'm closing this PR. PHP 7.2 is supported since v2