matteosister / GitElephant

An abstraction layer for git written in PHP
GNU Lesser General Public License v3.0
613 stars 74 forks source link

Release v2.1.0 #141

Closed GenieTim closed 6 years ago

GenieTim commented 6 years ago
imunhatep commented 6 years ago

I'm fine to release v2.1. Just a minor question - are you suggesting to squash commits? cause I used to merge directly, saving commit history..

GenieTim commented 6 years ago

I am sorry, what commits are you referencing to? I am sorry, if I did squash any commits, it was by accident, although I am pretty sure I paid attention to execute the commands as they were suggested by GitHubs merge instructions...

imunhatep commented 6 years ago

No no, I mean github currently (for this MR) suggests to "Squash and merge" (check green button for merging) and I was wondering if this is default behavior for github or this is MR specific and could be controlled by MR issuer?!

updated: seems this is just a default behavior for github.. I suggest to merge these changes without squashing?

GenieTim commented 6 years ago

Ah sorry, yeah, without squashing is alright. For me, somehow, squashing is not the default:

squashing is not the default.

But yeah, I will then proceed to publish, thanks.