update to php 7.1 - Githubissues

matteosister / GitElephant

An abstraction layer for git written in PHP

GNU Lesser General Public License v3.0

613 stars 74 forks source link

update to php 7.1 #152

Closed rvitaliy closed 5 years ago

rvitaliy commented 6 years ago

based on the php roadmap http://php.net/supported-versions.php I would propose to update the php requirement of the project to version "^7.1"

GenieTim commented 6 years ago

Thanks for your contribution! What is the benefit of dropping support for symfony components 3.x?

rvitaliy commented 6 years ago

they're not support php 7 https://github.com/symfony/filesystem/blob/3.2/composer.json but i see they start to support it from >= 3.3 https://github.com/symfony/filesystem/blob/3.3/composer.json so we can change requirements to "symfony/filesystem": "^3.3|^4.0"

GenieTim commented 6 years ago

That is not true. Just because they do not require PHP 7 does not mean they do not support it – I was running a full Symfony 2.8 application (untill recently when I upgraded) successfully under PHP 7.2...

rvitaliy commented 6 years ago

I misunderstood the behavior of the composer, sorry, i rollback the changes.

imunhatep commented 5 years ago

As I understand there is nothing to merge?! Can we close this MR?