matteosister / GitElephant

An abstraction layer for git written in PHP
GNU Lesser General Public License v3.0
613 stars 74 forks source link

Replace Repo::getTree() with a contrib Tree implementation #171

Closed drupol closed 1 year ago

drupol commented 4 years ago

Hi,

Yesterday while doing #169 I noticed that you have an implementation of a tree structure for Git, which make totally sense.

I was wondering if you would be interested to look at this package. It's a full blown tree data structure, fast, maintained and tested.

You could get rid of the current tree implementation from this package and delegate it to PHPTree.

What do you think?

GenieTim commented 4 years ago

Hi and thanks for reaching out!

I see both pros and cons to this:

Cons:

Pros:

I see it as a valid option for a next major version of this library (if @Imunhatep does not have major concerns), but not something I would spend time on changing myself.