search

matteosister / GitElephant

An abstraction layer for git written in PHP
GNU Lesser General Public License v3.0
613 stars 74 forks source link

fix-rename-status #173

Closed yunwuxin closed 3 years ago

imunhatep commented 3 years ago

Thank you for contribution.

Seems: PSR2 was deprecated.. and ecs check complains about it.

Try to remove line in: [https://github.com/matteosister/GitElephant/blob/develop/ecs.yaml#L5]()

So the beginning would look like this:

# ecs.yml
parameters:
    sets:
        - 'clean-code'
        - 'psr12'
imunhatep commented 3 years ago

@GenieTim Hey, any comments from you as I plan to merge it?!

GenieTim commented 3 years ago

Hey you two, thanks for your work! I was looking into the issue with ecs and kinda got lost there, sorry. This PR looks fine to me, thanks!