search

matteosister / GitElephant

An abstraction layer for git written in PHP
GNU Lesser General Public License v3.0
613 stars 74 forks source link

Fixed a bug wherein the interface for submodule update #79

Closed adamlacoste closed 9 years ago

adamlacoste commented 9 years ago

Fixed a bug wherein the interface for submodule update with --init, --force and --recursive flags was ignoring those flags. This is an old feature I submitted that I'm only now getting around to implementing, so I wanted to share this bug fix with the project.

adamlacoste commented 9 years ago

Added a second commit which addresses another bug: the SubmoduleCommand::getInstance() call wasn't being passed a repo object, so it wasn't honoring global options. Normally I'd have made this a separate pull request but the two changes are on the same line and would have conflicted otherwise.

adamlacoste commented 9 years ago

@matteosister When do you anticipate the next version of gitelephant will be released? I've got the fix for this bug in my test environment but until it joins the master branch and gets fetched by composer in new installations, there's a limit to how far my work can go.

matteosister commented 9 years ago

@adamlacoste my fault...I gonna merge this and release NOW!

matteosister commented 9 years ago

@adamlacoste v1.0.11 released!!! Sorry again...

adamlacoste commented 9 years ago

Thanks @matteosister, I appreciate it. And thanks for maintaining this project, it has been a huge time saver for me.